Updated release scripts to work around GitHub / Circle CI integration problems #21434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
commented
May 5, 2021
| const message = theme` | ||
| {caution An experimental build has been downloaded!} | ||
|
|
||
| You can download this build again by running: | ||
| {path ${commandPath}} --commit={commit ${commit}} | ||
| {path ${commandPath}} --build={build ${build}} |
There was a problem hiding this comment.
No sense for e.g. Firefox reviewer to have to re-run the commit-to-build check when we already have the build ID.
bvaughn
force-pushed
the
update-release-script-to-add-status-workaround
branch
from
8f2812a to
93782cf
Compare
|
Comparing: 014edf1...93782cf Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
I'm going to merge this b'c it's blocking another DevTools release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub/CircleCI issue is blocking the DevTools release 😦
This updates the release scripts so they can accept a
--buildparameter in addition to a--commitparameter.So before we would run either:
scripts/release/download-experimental-build.js # defaults to latest in masterWe can still do that now, explicitly:
But we can also do:
Here's it working even with a revision that GitHub/CircleCI are out of sync on:
