Move IE8 onscroll check #2175
Closed
Move IE8 onscroll check #2175
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than checking if document.onscroll exists in EventPluginHub (which is agnostic of the DOM) do it in ReactDOMComponent
|
lgtm. This might live better in a didPutListener hook in SimpleEventPlugin but I think my diff adding that was reverted and hasn't been reapplied yet. |
|
Nice! It's great to get all of the dom references out of the event plugin which is very agnostic to the context it's running in (or should be). |
|
👍 @arasmussen want to fix the test we have for this error? |
|
Moving over to #2181 with an extra commit for the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than checking if document.onscroll exists in EventPluginHub
(which is agnostic of the DOM) do it in ReactDOMComponent