-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New devtools test for named hooks verifying case when hooks are used indirectly #21996
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow | ||
*/ | ||
|
||
import React, {useEffect, useState} from 'react'; | ||
|
||
export function Component() { | ||
const countState = useState(0); | ||
const count = countState[0]; | ||
const setCount = countState[1]; | ||
|
||
const darkMode = useIsDarkMode(); | ||
const [isDarkMode, setDarkMode] = darkMode; | ||
|
||
useEffect(() => { | ||
// ... | ||
}, []); | ||
|
||
const handleClick = () => setCount(count + 1); | ||
|
||
return ( | ||
<> | ||
<div>Dark mode? {isDarkMode}</div> | ||
<div>Count: {count}</div> | ||
<button onClick={handleClick}>Update count</button> | ||
</> | ||
); | ||
} | ||
|
||
function useIsDarkMode() { | ||
const darkModeState = useState(false); | ||
const [isDarkMode] = darkModeState; | ||
|
||
useEffect(function useEffectCreate() { | ||
// Here is where we may listen to a "theme" event... | ||
}, []); | ||
|
||
return [isDarkMode, () => {}]; | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the empty
useEffect
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this file is just a fixture for a test. we use it in this fixture and assert that we don't generate a name for this hook, since naming hooks like useEffect doesn't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I get it that confirming shouldn't generate name, thanks!