Enable enableSuspenseLayoutEffectSemantics flag statically for Facebook #22050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
|
Comparing: 6493182...605b335 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
jstejada
approved these changes
Aug 9, 2021
| @@ -18,7 +18,6 @@ export const disableInputAttributeSyncing = __VARIANT__; | |||
| export const enableFilterEmptyStringAttributesDOM = __VARIANT__; | |||
| export const enableLegacyFBSupport = __VARIANT__; | |||
| export const skipUnmountedBoundaries = __VARIANT__; | |||
| export const enableSuspenseLayoutEffectSemantics = __VARIANT__; | |||
There was a problem hiding this comment.
just curious, what's the purpose of the __VARIANT__ value?
There was a problem hiding this comment.
For dynamic flags, we use the __VARIANT__ setting to ensure that automated tests run with both values (enabled and disabled) so we don't accidentally break one.
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 17, 2021
Summary: This sync includes the following changes: - **[424fe5870](facebook/react@424fe5870 )**: Revert "Show a soft error when a text string or number is supplied as a child to non text wrappers ([#21953](facebook/react#21953))" ([#22108](facebook/react#22108)) //<Sota>// - **[aebf3b456](facebook/react@aebf3b456 )**: [Scheduler] Check for continuous input events ([#22107](facebook/react#22107)) //<Andrew Clark>// - **[e9b2028b3](facebook/react@e9b2028b3 )**: Show a soft error when a text string or number is supplied as a child to non text wrappers ([#21953](facebook/react#21953)) //<Sota>// - **[ecd73e17b](facebook/react@ecd73e17b )**: Enable enableSuspenseLayoutEffectSemantics flag statically for Facebook ([#22050](facebook/react#22050)) //<Brian Vaughn>// - **[a8725a3e6](facebook/react@a8725a3e6 )**: Scheduling profiler: Added lane labels and durations to React measures ([#22029](facebook/react#22029)) //<Brian Vaughn>// Changelog: [General][Changed] - React Native sync for revisions 19092ac...5634ed1 jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D30225923 fbshipit-source-id: 562895d3e0d264f40770dadb89d4a16241967c4c
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag has been rolled out on Facebook at 10% public for ~3 weeks with no stat sig negative impact so let's enable it statically for Facebook builds.