Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement useSyncExternalStore in Fiber #22239

Merged
merged 1 commit into from
Sep 7, 2021

Commits on Sep 7, 2021

  1. Implement useSyncExternalStore in Fiber

    This adds an initial implementation of useSyncExternalStore to the
    fiber reconciler. It's mostly a copy-paste of the userspace
    implementation, which is not ideal but is a good enough starting place.
    
    The main change we'll want to make to this native implementation is to
    move the tearing checks from the layout phase to an earlier, pre-commit
    phase so that code that runs in the commit phase always observes a
    consistent tree.
    
    Follow-ups:
    
    - Implement in Fizz
    - Implement in old SSR renderer
    - Implement in react-debug-hooks
    acdlite committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    15bb962 View commit details
    Browse the repository at this point in the history