Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape warning messages in CI #22393

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 22, 2021

There's a downstream workflow that runs the print-warnings command. We can make it faster by scraping the warnings in CI and storing the result as a build artifact.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Sep 22, 2021
@sizebot
Copy link

sizebot commented Sep 22, 2021

Comparing: ba07042...359ceea

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.37 kB 127.37 kB = 40.58 kB 40.58 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.19 kB 130.19 kB = 41.50 kB 41.50 kB
facebook-www/ReactDOM-prod.classic.js = 405.41 kB 405.41 kB = 75.05 kB 75.05 kB
facebook-www/ReactDOM-prod.modern.js = 394.00 kB 394.00 kB = 73.34 kB 73.34 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.41 kB 405.41 kB = 75.05 kB 75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 359ceea

There's a downstream workflow that runs the `print-warnings` command. We
can make it faster by scraping the warnings in CI and storing the
result as a build artifact.
@acdlite acdlite merged commit 8fcfdff into facebook:main Sep 22, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
There's a downstream workflow that runs the `print-warnings` command. We
can make it faster by scraping the warnings in CI and storing the
result as a build artifact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants