-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CodeSandbox to pull build artifacts from CI #22400
Update CodeSandbox to pull build artifacts from CI #22400
Conversation
7e1846a
to
13405f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were we doing the experimental build before, or is that new?
Comparing: 51e017c...92f42ad Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
13405f0
to
dc98fb9
Compare
@rickhanlonii I think it was using the stable ones but not intentionally, just because that's the default for the |
12aa55d
to
1a56f87
Compare
Instead of building them from source. The `download-experimental-build` script polls CI until the build has finished.
1a56f87
to
92f42ad
Compare
Should it be stable/alpha until 18 lands? |
@rickhanlonii The reason I went with experimental is because it's a superset of the features in stable. I think the best argument for keeping them as stable is if someone submits a bug report that only affects stable, then the CodeSandbox on a bugfix PR could show it as "fixed" even if it's still broken in stable. But since our bugfix PRs are required to include a jest regression test anyway I'm not too worried about that. |
Instead of building them from source. The `download-experimental-build` script polls CI until the build has finished.
Instead of building them from source.
The
download-experimental-build
script polls CI until the build has finished.