Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeSandbox to pull build artifacts from CI #22400

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 22, 2021

Instead of building them from source.

The download-experimental-build script polls CI until the build has finished.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 22, 2021
@acdlite acdlite force-pushed the codesandbox-ci-download-artifacts branch from 7e1846a to 13405f0 Compare September 22, 2021 17:43
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we doing the experimental build before, or is that new?

@sizebot
Copy link

sizebot commented Sep 22, 2021

Comparing: 51e017c...92f42ad

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.52 kB 129.52 kB = 41.28 kB 41.28 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.34 kB 132.34 kB = 42.22 kB 42.22 kB
facebook-www/ReactDOM-prod.classic.js = 411.10 kB 411.10 kB = 76.08 kB 76.08 kB
facebook-www/ReactDOM-prod.modern.js = 399.67 kB 399.67 kB = 74.37 kB 74.37 kB
facebook-www/ReactDOMForked-prod.classic.js = 411.10 kB 411.10 kB = 76.08 kB 76.09 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 92f42ad

@acdlite acdlite force-pushed the codesandbox-ci-download-artifacts branch from 13405f0 to dc98fb9 Compare September 22, 2021 17:48
@acdlite
Copy link
Collaborator Author

acdlite commented Sep 22, 2021

@rickhanlonii I think it was using the stable ones but not intentionally, just because that's the default for the build command

@acdlite acdlite force-pushed the codesandbox-ci-download-artifacts branch 2 times, most recently from 12aa55d to 1a56f87 Compare September 22, 2021 17:59
Instead of building them from source.

The `download-experimental-build` script polls CI until the build
has finished.
@acdlite acdlite force-pushed the codesandbox-ci-download-artifacts branch from 1a56f87 to 92f42ad Compare September 22, 2021 18:02
@rickhanlonii
Copy link
Member

Should it be stable/alpha until 18 lands?

@acdlite
Copy link
Collaborator Author

acdlite commented Sep 22, 2021

@rickhanlonii The reason I went with experimental is because it's a superset of the features in stable.

I think the best argument for keeping them as stable is if someone submits a bug report that only affects stable, then the CodeSandbox on a bugfix PR could show it as "fixed" even if it's still broken in stable. But since our bugfix PRs are required to include a jest regression test anyway I'm not too worried about that.

@acdlite acdlite merged commit 95502f7 into facebook:main Sep 22, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Instead of building them from source.

The `download-experimental-build` script polls CI until the build
has finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants