Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Errors should not "unsuspend" a transition #22423

Merged
merged 1 commit into from
Sep 27, 2021
Merged

[Fix] Errors should not "unsuspend" a transition #22423

merged 1 commit into from
Sep 27, 2021

Commits on Sep 24, 2021

  1. [Fix] Errors should not "unsuspend" a transition 

    If an error is thrown during a transition where we would have otherwise
suspended without showing a fallback (i.e. during a refresh), we should
still suspend.

The current behavior is that the error will force the fallback to
appear, even if it's completely unrelated to the component that errored,
which breaks the contract of `startTransition`.
    @acdlite
    acdlite committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    8645118 View commit details
    Browse the repository at this point in the history