Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that discrete events that aren't hydratable do not propagate #22502

Merged
merged 8 commits into from
Oct 6, 2021
Merged

Test that discrete events that aren't hydratable do not propagate #22502

merged 8 commits into from
Oct 6, 2021

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Oct 4, 2021

Summary

This test case shows that we don't propagate discrete events that aren't synchronously hydratable.

@salazarm salazarm mentioned this pull request Oct 4, 2021
Merged
@sizebot
Copy link

sizebot commented Oct 4, 2021 •
edited
Loading

Comparing: f2c3811...08c833b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.05 kB 130.05 kB = 41.34 kB 41.34 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.88 kB 132.88 kB = 42.30 kB 42.31 kB
facebook-www/ReactDOM-prod.classic.js +0.04% 413.66 kB 413.81 kB +0.03% 76.44 kB 76.47 kB
facebook-www/ReactDOM-prod.modern.js +0.04% 402.24 kB 402.39 kB +0.03% 74.71 kB 74.74 kB
facebook-www/ReactDOMForked-prod.classic.js +0.04% 413.66 kB 413.81 kB +0.03% 76.45 kB 76.47 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 08c833b

@salazarm
Copy link
Contributor Author

salazarm commented Oct 4, 2021 •
edited
Loading

--edit-- test works as expected... I had binded to onClick instead of onclick on the ref😅

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Oct 5, 2021
sebmarkbage
sebmarkbage approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@salazarm salazarm merged commit 6ecad79 into facebook:main Oct 6, 2021
@salazarm salazarm deleted the alsoStopPropagationIfHydrationFails branch October 6, 2021 12:31
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
@salazarm @zhengjitf
Test that discrete events that aren't hydratable do not propagate (fa…
1462a2e 
…cebook#22502)

* test that discrete events that arent hydratable do not propagate

* lint

* feedback

* feedback

* lint

* better test

* nits

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salazarm @sizebot @sebmarkbage @facebook-github-bot