Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onErrorShell and Make renderToReadableStream a Promise #23247

Merged
merged 1 commit into from
Feb 9, 2022

Commits on Feb 8, 2022

  1. Add onErrorShell Callback

    This indicates that an error has happened before the shell completed and
    there's no point in emitting the result of this stream.
    
    This is not quite the same as other fatal errors that can happen even
    after streaming as started.
    
    It's also not quite the same as onError before onCompleteShell because
    onError can be called for an error inside a Suspense boundary before the
    shell completes.
    
    Implement shell error handling in Node SSR fixtures
    
    Instead of hanging indefinitely.
    
    Update Browser Fixture
    
    Expose onErrorShell to the Node build
    
    This API is not Promisified so it's just a separate callback instead.
    
    Promisify the Browser Fizz API
    
    It's now a Promise of a readable stream. The Promise resolves when the
    shell completes. If the shell errors, the Promise is rejected.
    sebmarkbage committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    b96ae0e View commit details
    Browse the repository at this point in the history