Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove path resolution from internal forks plugin #23255

Merged
merged 1 commit into from
Feb 9, 2022

Commits on Feb 9, 2022

  1. Remove path resolution from internal forks plugin

    Alternative to facebook#23254
    
    Our build script has a custom plugin to resolve internal module forks.
    Currently, it uses require.resolve to resolve the path to a real file
    on disk.
    
    Instead, I've updated all the forked module paths to match their
    location on disk, relative to the project root, to remove the need to
    resolve them in the build script's runtime.
    
    The main motivation is because require.resolve doesn't work with ESM
    modules, but aside from that, hardcoding the relative paths is more
    predictable — the Node module resolution algorithm is complicated, and
    we don't really need its features for this purpose.
    acdlite committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    197d453 View commit details
    Browse the repository at this point in the history