Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cache pool contexts #23280

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Feb 11, 2022

The pooledCache variable always points to either root.pooledCache or the stack cursor that is used to track caches that were resumed from a previous render. We can get rid of it by reading from those instead. This simplifies the code a lot and is harder to mess up, I think.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 11, 2022
@sizebot
Copy link

sizebot commented Feb 11, 2022

Comparing: 64223fe...95495c0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.35 kB 130.35 kB = 41.83 kB 41.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 135.54 kB 135.33 kB = 43.35 kB 43.26 kB
facebook-www/ReactDOM-prod.classic.js = 431.29 kB 430.69 kB = 79.12 kB 79.04 kB
facebook-www/ReactDOM-prod.modern.js = 421.18 kB 420.57 kB = 77.67 kB 77.57 kB
facebook-www/ReactDOMForked-prod.classic.js = 431.29 kB 430.69 kB = 79.12 kB 79.04 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactART-prod.classic.js = 277.85 kB 277.28 kB = 49.36 kB 49.28 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 96.82 kB 96.62 kB = 29.69 kB 29.60 kB
facebook-www/ReactART-prod.modern.js = 270.16 kB 269.58 kB = 48.09 kB 47.99 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 89.20 kB 88.99 kB = 27.71 kB 27.64 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 88.97 kB 88.77 kB = 27.43 kB 27.34 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 86.56 kB 86.35 kB = 26.77 kB 26.69 kB

Generated by 🚫 dangerJS against 95495c0

@acdlite acdlite marked this pull request as draft February 11, 2022 20:08
@acdlite acdlite force-pushed the simplify-cache-context branch from 771740e to 93eca77 Compare February 11, 2022 20:16
The `pooledCache` variable always points to either `root.pooledCache`
or the stack cursor that is used to track caches that were resumed from
a previous render. We can get rid of it by reading from those instead.
This simplifies the code a lot and is harder to mess up, I think.
@acdlite acdlite force-pushed the simplify-cache-context branch from 93eca77 to 95495c0 Compare February 11, 2022 22:18
@acdlite acdlite marked this pull request as ready for review February 11, 2022 22:18
@acdlite acdlite merged commit 27b5699 into facebook:main Feb 11, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Feb 17, 2022
Summary:
This sync includes the following changes:
- **[27b569969](facebook/react@27b569969 )**: Simplify cache pool contexts ([#23280](facebook/react#23280)) //<Andrew Clark>//
- **[1fb0d0687](facebook/react@1fb0d0687 )**: [Devtools][Transition Tracing] Add Transition callbacks to createRoot ([#23276](facebook/react#23276)) //<Luna Ruan>//
- **[a6987bee7](facebook/react@a6987bee7 )**: add <TracingMarker> component boilerplate ([#23275](facebook/react#23275)) //<Luna Ruan>//
- **[796fff548](facebook/react@796fff548 )**: Allow suspending outside a Suspense boundary ([#23267](facebook/react#23267)) //<Andrew Clark>//
- **[64223fed8](facebook/react@64223fed8 )**: Fix: Multiple hydration errors in same render ([#23273](facebook/react#23273)) //<Andrew Clark>//
- **[efd8f6442](facebook/react@efd8f6442 )**: Resolve default onRecoverableError at root init ([#23264](facebook/react#23264)) //<Andrew Clark>//
- **[e0af1aabe](facebook/react@e0af1aabe )**: Fix wrong context argument to `apply` //<Andrew Clark>//
- **[9b5e0517b](facebook/react@9b5e0517b )**: Remove deprecated wildcard folder mapping ([#23256](facebook/react#23256)) //<Andrew Clark>//
- **[274b9fb16](facebook/react@274b9fb16 )**: Remove path resolution from internal forks plugin ([#23255](facebook/react#23255)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a3bde79...27b5699

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii, kacieb

Differential Revision: D34241986

fbshipit-source-id: f6ab62df2a918728864283b4f13201275eb3b8a3
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
The `pooledCache` variable always points to either `root.pooledCache`
or the stack cursor that is used to track caches that were resumed from
a previous render. We can get rid of it by reading from those instead.
This simplifies the code a lot and is harder to mess up, I think.
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
This sync includes the following changes:
- **[27b569969](facebook/react@27b569969 )**: Simplify cache pool contexts ([facebook#23280](facebook/react#23280)) //<Andrew Clark>//
- **[1fb0d0687](facebook/react@1fb0d0687 )**: [Devtools][Transition Tracing] Add Transition callbacks to createRoot ([facebook#23276](facebook/react#23276)) //<Luna Ruan>//
- **[a6987bee7](facebook/react@a6987bee7 )**: add <TracingMarker> component boilerplate ([facebook#23275](facebook/react#23275)) //<Luna Ruan>//
- **[796fff548](facebook/react@796fff548 )**: Allow suspending outside a Suspense boundary ([facebook#23267](facebook/react#23267)) //<Andrew Clark>//
- **[64223fed8](facebook/react@64223fed8 )**: Fix: Multiple hydration errors in same render ([facebook#23273](facebook/react#23273)) //<Andrew Clark>//
- **[efd8f6442](facebook/react@efd8f6442 )**: Resolve default onRecoverableError at root init ([facebook#23264](facebook/react#23264)) //<Andrew Clark>//
- **[e0af1aabe](facebook/react@e0af1aabe )**: Fix wrong context argument to `apply` //<Andrew Clark>//
- **[9b5e0517b](facebook/react@9b5e0517b )**: Remove deprecated wildcard folder mapping ([facebook#23256](facebook/react#23256)) //<Andrew Clark>//
- **[274b9fb16](facebook/react@274b9fb16 )**: Remove path resolution from internal forks plugin ([facebook#23255](facebook/react#23255)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions a3bde79...27b5699

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii, kacieb

Differential Revision: D34241986

fbshipit-source-id: f6ab62df2a918728864283b4f13201275eb3b8a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants