#2325 : Add $inc support for Helpers update

[ThomasCrevoisier]

No description provided.

[syranide]

As far as I understand update it looks great. AFAIK the intention was to imitate the MongoDB interface which does support inc, but I'm not sure if it's really necessary in React as you can just add to the value directly (obviously a bit more verbose though) and update is intended to just be a really simple helper.

That being said, big thanks for contributing, I'd love to find something of significance that you could attack... :)

[ThomasCrevoisier]

I see ^^ Well, the feature was quite simple to implement, so it's no big deal. And I'd love to work on something more significant :)

[totty90]

Hy! Thanks (: This would be really helpful to be included. As I've explained here: #2325

This would allow to reuse the same code for a mongodb database as in my case. If you want to reuse the logic between client and server side this would be an amazing addition. Waiting to be included. Currently I have the same logic, but somewhere is duplicated because I need update and the $inc doesn't work yet.

For example this is the logic which runs both on client and on server:

var update = {};
job.time += 0.2;
updates.job = {$inc: {time: 0.2}};
return updates;

This issue solves this problem:

var update = {};
updates.job = {$inc: {time: 0.2}};
return updates;

// outside of that method, on the client side
update(job, updates.job);

Notice that I don't have duplicated logic, which is a pain to maintain (job.time += 0.2; and {$inc: {time: 0.2}};).

In the future more people will use this technique to predict on the client and validate/update on the server using the exact same logic. Is very DRY and less prone to errors, inconsistencies.

[syranide]

@totty90 If your goal is to be compatible with MongoDB, I would recommend that you fork/reimplement this helper for that specific goal. That's not to say it shouldn't be added to this React addon, but AFAIK MongoDB is just an inspiration for this helper, not the goal (as far as I'm aware, it's provided just to kickstart people who are new to React).

[totty90]

@syranide Yes, I understand. But if we can both find some common use, I would appreciate. I would not like to keep a different fork of react.. And other people might even use it this way.

[syranide]

@totty90 React.addons.* is not part of React, it's just shipped as part of the React bundle for now. The plan is to move them out into separate NPM modules when everything is figured out, wiki link. React.addons.update has no React core dependencies.

[totty90]

@syranide I know about that. Maybe at least allow to monkey patch the lib externally, at runtime, without the need of a fork could be a solution?

[chenglou]

@petehunt

[sebmarkbage]

update is deprecated in favor of immutable.js

We don't want to turn this into a DSL.

[gaearon]

You might be interested in https://github.com/kolodny/immutability-helper that lets you define custom operations by name.

[facebook-github-bot]

@ThomasCrvsr updated the pull request.