Drop Legacy Factories #2375
Merged
Drop Legacy Factories #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
force-pushed
the
droplegacyfactories
branch
2 times, most recently
from
7d15b28
to
d88fed6
Compare
| mockInstance[key] = ReactCompositeComponentBase.prototype[key]; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a hack to restore internal methods to their unmocked state. In a follow up PR, these internals will be moved off the class instances and therefore they won't get mocked.
sebmarkbage
force-pushed
the
droplegacyfactories
branch
3 times, most recently
from
e33c8ea
to
c28d2de
Compare
| mocks = require('mocks'); | ||
|
|
||
| React = require('React'); | ||
| ReactComponent = require('ReactComponent'); |
There was a problem hiding this comment.
This is probably why the test is "failing"
There was a problem hiding this comment.
Fixed. CI now passes.
sebmarkbage
force-pushed
the
droplegacyfactories
branch
from
c28d2de
to
b542f6e
Compare
|
|
These used to be exposed as strings on the legacy factories but are now gone.
Classes are now pure classes without a legacy factory around them. Since classes will become just any function that returns a valid instance, let's drop isValidClass. There's some hacks in here for auto-mocking frameworks (jest) that mock the prototype of these classes. These hacks allow these classes to be mounted.
sebmarkbage
force-pushed
the
droplegacyfactories
branch
from
b542f6e
to
9b36b04
Compare
|
Changes Unknown when pulling 9b36b04 on sebmarkbage:droplegacyfactories into * on facebook:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is post-0.12 changes. It drops the legacy factory from around the class.