Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gender neutral terms #24225

Closed
wants to merge 1 commit into from
Closed

Switch to gender neutral terms #24225

wants to merge 1 commit into from

Conversation

inclusive-coding-bot
Copy link

Hey! We noticed your repository had a few instances of gendered language. We've attempted to make the changes to gender neutral language :)

You can learn more about this project and why gender neutral language matters at inclusivecoding.wixsite.com. If you have feedback for this bot, please provide it here.

@facebook-github-bot
Copy link

Hi @inclusive-coding-bot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@@ -366,7 +366,7 @@ describe('InspectedElement', () => {
const Wrapper = ({children}) => children;
const Target = React.memo(props => {
targetRenderCount++;
// Even though his hook isn't referenced, it's used to observe backend rendering.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is supposed to be "this"

@gaearon
Copy link
Collaborator

gaearon commented Mar 30, 2022

Thanks for the PR, but this approach is not productive. It's only creating noise.

  • The first example is a typo. (It should be "this", not "his")
  • The second example is not part of React and is a checked-in copy of another package, so it should not be changed. (It'll reset next time it's updated.)

Please don't use bots on this repository.

@gaearon gaearon closed this Mar 30, 2022
@facebook facebook locked as spam and limited conversation to collaborators Mar 30, 2022
@gaearon
Copy link
Collaborator

gaearon commented Mar 30, 2022

I should note if there are actual examples of unnecessarily gendered language in the React repo, we will happily take the fix. This is not an example of that, and judging by PRs like freeCodeCamp/freeCodeCamp#45569, this bot could use a lot of work before it's good enough to send PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants