Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide children of Offscreen after destroy effects #24446

Merged
merged 1 commit into from
May 3, 2022

Conversation

rickhanlonii
Copy link
Member

Will quickly test internally then land the flag everywhere.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 26, 2022
@sizebot
Copy link

sizebot commented Apr 26, 2022

Comparing: 6bf3dee...8c2baef

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.56 kB 131.56 kB = 42.11 kB 42.11 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.83 kB 136.83 kB = 43.69 kB 43.69 kB
facebook-www/ReactDOM-prod.classic.js = 441.15 kB 440.61 kB = 80.48 kB 80.48 kB
facebook-www/ReactDOM-prod.modern.js = 426.40 kB 425.86 kB = 78.28 kB 78.27 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.15 kB 440.61 kB = 80.48 kB 80.48 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-dev.modern.js +0.91% 9.98 kB 10.07 kB +0.85% 2.58 kB 2.60 kB
facebook-www/ReactIs-dev.classic.js +0.91% 9.98 kB 10.07 kB +0.85% 2.58 kB 2.60 kB
facebook-www/ReactFlightDOMRelayClient-dev.modern.js +0.71% 12.74 kB 12.84 kB +0.64% 3.76 kB 3.78 kB
facebook-www/ReactFlightDOMRelayClient-dev.classic.js +0.71% 12.75 kB 12.84 kB +0.67% 3.76 kB 3.78 kB
facebook-www/ReactFreshRuntime-dev.modern.js +0.40% 22.93 kB 23.02 kB +0.37% 6.67 kB 6.69 kB
facebook-www/ReactFreshRuntime-dev.classic.js +0.40% 22.93 kB 23.02 kB +0.37% 6.67 kB 6.69 kB

Generated by 🚫 dangerJS against 8c2baef

@acdlite
Copy link
Collaborator

acdlite commented Apr 26, 2022

Does this really need to be gated?

@rickhanlonii
Copy link
Member Author

I think either @gaearon or @sebmarkbage recommended gating it in case there is an issue.

@gaearon
Copy link
Collaborator

gaearon commented Apr 26, 2022

I think I was referring to a different change (the one Andrew did). I don’t know whether this one would benefit from gating

@acdlite
Copy link
Collaborator

acdlite commented Apr 26, 2022

Needs a test

Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make up a test but it's a little tricky to come up with a realistic one since the observable difference is mainly whether it has a layout or not and even that is not true if we use content-visibility to keep the layout.

Since display: none has no effect in JS DOM, it seems like the only way to write the test is assert on implementation details (i.e. is display: none set).

@rickhanlonii rickhanlonii merged commit 99eef9e into facebook:main May 3, 2022
@rickhanlonii rickhanlonii deleted the rh-flip-order branch May 3, 2022 14:16
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 6, 2022
Summary:
This sync includes the following changes:
- **[dd4950c90](facebook/react@dd4950c90 )**: [Flight] Implement useId hook ([#24172](facebook/react#24172)) //<Josh Story>//
- **[26a5b3c7f](facebook/react@26a5b3c7f )**: Explicitly set `highWaterMark` to 0 for `ReadableStream` ([#24641](facebook/react#24641)) //<Josh Larson>//
- **[aec575914](facebook/react@aec575914 )**: [Fizz] Send errors down to client ([#24551](facebook/react#24551)) //<Josh Story>//
- **[a2766387e](facebook/react@a2766387e )**: [Fizz] Improve text separator byte efficiency ([#24630](facebook/react#24630)) //<Josh Story>//
- **[f7860538a](facebook/react@f7860538a )**: Fix typo in useSyncExternalStore main entry point error ([#24631](facebook/react#24631)) //<François Chalifour>//
- **[1bed20731](facebook/react@1bed20731 )**: Add a module map option to the Webpack Flight Client ([#24629](facebook/react#24629)) //<Sebastian Markbåge>//
- **[b2763d3ea](facebook/react@b2763d3ea )**: Move hydration code out of normal Suspense path ([#24532](facebook/react#24532)) //<Andrew Clark>//
- **[357a61324](facebook/react@357a61324 )**: [DevTools][Transition Tracing] Added support for Suspense Boundaries ([#23365](facebook/react#23365)) //<Luna Ruan>//
- **[2c8a1452b](facebook/react@2c8a1452b )**: Fix ignored setState in Safari when iframe is touched ([#24459](facebook/react#24459)) //<dan>//
- **[62662633d](facebook/react@62662633d )**: Remove enableFlipOffscreenUnhideOrder ([#24545](facebook/react#24545)) //<Ricky>//
- **[34da5aa69](facebook/react@34da5aa69 )**: Only treat updates to lazy as a new mount in legacy mode ([#24530](facebook/react#24530)) //<Ricky>//
- **[46a6d77e3](facebook/react@46a6d77e3 )**: Unify JSResourceReference Interfaces ([#24507](facebook/react#24507)) //<Timothy Yung>//
- **[6cbf0f7fa](facebook/react@6cbf0f7fa )**: Fork ReactSymbols ([#24484](facebook/react#24484)) //<Ricky>//
- **[a10a9a6b5](facebook/react@a10a9a6b5 )**: Add test for hiding children after layout destroy ([#24483](facebook/react#24483)) //<Ricky>//
- **[b4eb0ad71](facebook/react@b4eb0ad71 )**: Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored ([#24480](facebook/react#24480)) //<Josh Story>//
- **[99eef9e2d](facebook/react@99eef9e2d )**: Hide children of Offscreen after destroy effects ([#24446](facebook/react#24446)) //<Ricky>//
- **[ce1386028](facebook/react@ce1386028 )**: Remove enablePersistentOffscreenHostContainer flag ([#24460](facebook/react#24460)) //<Andrew Clark>//
- **[72b7462fe](facebook/react@72b7462fe )**: Bump local package.json versions for 18.1 release ([#24447](facebook/react#24447)) //<Andrew Clark>//
- **[22edb9f77](facebook/react@22edb9f77 )**: React `version` field should match package.json ([#24445](facebook/react#24445)) //<Andrew Clark>//
- **[6bf3deef5](facebook/react@6bf3deef5 )**: Upgrade react-shallow-renderer to support react 18 ([#24442](facebook/react#24442)) //<Michael サイトー 中村 Bashurov>//

Changelog:
[General][Changed] - React Native sync for revisions bd4784c...d300ceb

jest_e2e[run_all_tests]

Reviewed By: cortinico, kacieb

Differential Revision: D36874368

fbshipit-source-id: c0ee015f4ef2fa56e57f7a1f6bc37dd05c949877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants