Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'hasAttribute' function to 'getAttribute' function in Danger.js #2472

Closed
wants to merge 1 commit into from

Conversation

joeadams0
Copy link

I have changed the 'hasAttribute' function to 'getAttribute' in Danger.js. The hasAttribute function was the only thing causing React to not work in IE7 when using the appropriate shims.

I tried to find a shim/sham to accomplish this, but it doesn't seem like it can be accomplished with it.

All tests pass, the lint doesn't, but it doesn't pass in master either.

@syranide
Copy link
Contributor

syranide commented Nov 6, 2014

The devs have explicitly rejected IE7 support, see #2169. While this may be one of the few things that prevents it from actually running, I'm sure there are many inconsistencies and presents major obstacles for further "React improvements". If you want this, fork an IE7 branch of React, or if someone has already made such a thing available. (EDIT: https://www.npmjs.org/package/react-ie)

cc @zpao

@syranide syranide closed this Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants