-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RulesOfHooks support for use
#25370
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
This was referenced Sep 30, 2022
poteto
added a commit
that referenced
this pull request
Sep 30, 2022
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. ghstack-source-id: 5d40c7262abb36e6d0abb89f80bdbfbe57163377 Pull Request resolved: #25370
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Sep 30, 2022
Comparing: 338e6a9...27e5f3e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
poteto
added a commit
that referenced
this pull request
Sep 30, 2022
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. ghstack-source-id: 35b7e1c341500cce364d5e006cb36e3ee12553d2 Pull Request resolved: #25370
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
poteto
added a commit
that referenced
this pull request
Sep 30, 2022
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. ghstack-source-id: fe4e7995be379f153a7ef1d1dd28bfa5be785427 Pull Request resolved: #25370
poteto
added a commit
that referenced
this pull request
Oct 4, 2022
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. ghstack-source-id: fe4e7995be379f153a7ef1d1dd28bfa5be785427 Pull Request resolved: #25370
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
poteto
added a commit
that referenced
this pull request
Oct 4, 2022
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. ghstack-source-id: 7ea5beceaf2c080f2c48821b5117bdd0c1194836 Pull Request resolved: #25370
acdlite
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! I don't know the linter codebase very well but the behavior looks correct to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
use
#25370Usage of the new
use
hook needs to conform to the rules of hooks, withthe one exception that it can be called conditionally.