Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow upgrade to 0.188 #25423

Closed
wants to merge 3 commits into from
Closed

Flow upgrade to 0.188 #25423

wants to merge 3 commits into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022 •
edited
Loading

@kassens
Flow upgrade to 0.188
35e6403 
[ghstack-poisoned]
@kassens kassens mentioned this pull request Oct 4, 2022
Closed
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.188
eef2573 
ghstack-source-id: 2902ae58ca9ca362aabd8ffb09f5c0235f39c341
Pull Request resolved: #25423
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.188
64c3c42 
ghstack-source-id: 3b1ae51f24d70cffa8669d9b8ee77d579ca78cf0
Pull Request resolved: #25423
@sizebot
Copy link

sizebot commented Oct 4, 2022 •
edited
Loading

Comparing: af9afe9...2180e90

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
oss-experimental/react-fs/cjs/react-fs.node.development.server.js +2.88% 10.41 kB 10.71 kB +0.24% 2.52 kB 2.52 kB
oss-stable-semver/react-fs/cjs/react-fs.node.development.server.js +2.88% 10.41 kB 10.71 kB +0.24% 2.52 kB 2.52 kB
oss-stable/react-fs/cjs/react-fs.node.development.server.js +2.88% 10.41 kB 10.71 kB +0.24% 2.52 kB 2.52 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-fs/cjs/react-fs.node.development.server.js +2.88% 10.41 kB 10.71 kB +0.24% 2.52 kB 2.52 kB
oss-stable-semver/react-fs/cjs/react-fs.node.development.server.js +2.88% 10.41 kB 10.71 kB +0.24% 2.52 kB 2.52 kB
oss-stable/react-fs/cjs/react-fs.node.development.server.js +2.88% 10.41 kB 10.71 kB +0.24% 2.52 kB 2.52 kB
oss-experimental/react-pg/cjs/react-pg.node.development.server.js +1.82% 2.97 kB 3.02 kB +2.06% 1.21 kB 1.24 kB
oss-stable-semver/react-pg/cjs/react-pg.node.development.server.js +1.82% 2.97 kB 3.02 kB +2.06% 1.21 kB 1.24 kB
oss-stable/react-pg/cjs/react-pg.node.development.server.js +1.82% 2.97 kB 3.02 kB +2.06% 1.21 kB 1.24 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-plugin.js +0.68% 9.55 kB 9.62 kB +0.33% 3.02 kB 3.03 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-plugin.js +0.68% 9.55 kB 9.62 kB +0.33% 3.02 kB 3.03 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-plugin.js +0.68% 9.55 kB 9.62 kB +0.33% 3.02 kB 3.03 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js +0.36% 18.04 kB 18.11 kB +0.75% 5.20 kB 5.24 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js +0.36% 18.04 kB 18.11 kB +0.75% 5.20 kB 5.24 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js +0.35% 18.44 kB 18.51 kB +0.70% 5.28 kB 5.32 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.29% 689.84 kB 691.85 kB +0.21% 149.91 kB 150.23 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.29% 689.86 kB 691.88 kB +0.21% 149.93 kB 150.25 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.29% 784.53 kB 786.79 kB +0.20% 166.98 kB 167.32 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.29% 784.56 kB 786.82 kB +0.20% 167.00 kB 167.34 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js +0.28% 722.58 kB 724.62 kB +0.20% 151.49 kB 151.79 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +0.28% 722.61 kB 724.65 kB +0.20% 151.51 kB 151.82 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.28% 718.71 kB 720.73 kB +0.25% 155.56 kB 155.94 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.28% 828.94 kB 831.25 kB +0.22% 175.58 kB 175.97 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +0.27% 752.90 kB 754.94 kB +0.22% 157.20 kB 157.55 kB
react-native/implementations/ReactFabric-dev.js +0.27% 810.89 kB 813.08 kB +0.16% 176.02 kB 176.30 kB
oss-stable-semver/react-server/cjs/react-server.development.js +0.26% 137.80 kB 138.17 kB +0.18% 34.51 kB 34.57 kB
oss-stable/react-server/cjs/react-server.development.js +0.26% 137.80 kB 138.17 kB +0.18% 34.51 kB 34.57 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.26% 732.80 kB 734.73 kB +0.21% 157.12 kB 157.45 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.26% 717.15 kB 719.04 kB +0.18% 154.78 kB 155.05 kB
oss-stable/react-art/cjs/react-art.development.js +0.26% 717.17 kB 719.06 kB +0.18% 154.80 kB 155.08 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.26% 754.79 kB 756.77 kB +0.20% 161.20 kB 161.53 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.26% 754.79 kB 756.77 kB +0.20% 161.20 kB 161.53 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +0.26% 22.65 kB 22.71 kB +0.56% 6.03 kB 6.06 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +0.26% 22.65 kB 22.71 kB +0.56% 6.03 kB 6.06 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +0.26% 22.65 kB 22.71 kB +0.56% 6.03 kB 6.06 kB
react-native/implementations/ReactFabric-dev.fb.js +0.26% 848.32 kB 850.51 kB +0.16% 182.69 kB 182.98 kB
oss-experimental/react-art/cjs/react-art.development.js +0.26% 758.49 kB 760.43 kB +0.20% 163.07 kB 163.39 kB
oss-experimental/react-server/cjs/react-server.development.js +0.25% 143.99 kB 144.35 kB +0.13% 35.91 kB 35.95 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.25% 820.39 kB 822.45 kB +0.14% 178.55 kB 178.81 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.24% 857.80 kB 859.86 kB +0.16% 185.25 kB 185.55 kB
facebook-www/ReactTestUtils-dev.modern.js +0.24% 50.08 kB 50.19 kB +0.41% 13.93 kB 13.99 kB
facebook-www/ReactTestUtils-dev.classic.js +0.24% 50.08 kB 50.19 kB +0.41% 13.93 kB 13.99 kB
oss-stable-semver/react-art/umd/react-art.development.js +0.23% 822.10 kB 824.01 kB +0.19% 172.89 kB 173.22 kB
oss-stable/react-art/umd/react-art.development.js +0.23% 822.12 kB 824.03 kB +0.19% 172.91 kB 173.23 kB
facebook-www/ReactART-dev.classic.js +0.23% 862.25 kB 864.23 kB +0.15% 181.62 kB 181.89 kB
oss-experimental/react-art/umd/react-art.development.js +0.23% 865.56 kB 867.53 kB +0.19% 181.23 kB 181.58 kB
facebook-www/ReactART-dev.modern.js +0.23% 851.99 kB 853.91 kB +0.16% 179.53 kB 179.81 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js +0.21% 55.82 kB 55.94 kB +0.32% 16.16 kB 16.21 kB
oss-stable/react-dom/cjs/react-dom-test-utils.development.js +0.21% 55.82 kB 55.94 kB +0.32% 16.16 kB 16.21 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.development.js +0.21% 55.86 kB 55.98 kB +0.32% 16.18 kB 16.23 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js +0.21% 1,066.46 kB 1,068.70 kB +0.16% 238.25 kB 238.63 kB
oss-stable/react-dom/cjs/react-dom.development.js +0.21% 1,066.49 kB 1,068.73 kB +0.16% 238.28 kB 238.65 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.20% 1,092.78 kB 1,095.02 kB +0.19% 243.98 kB 244.44 kB
oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js +0.20% 58.92 kB 59.04 kB +0.32% 16.40 kB 16.45 kB
oss-stable/react-dom/umd/react-dom-test-utils.development.js +0.20% 58.92 kB 59.04 kB +0.32% 16.40 kB 16.45 kB
oss-experimental/react-dom/umd/react-dom-test-utils.development.js +0.20% 58.97 kB 59.09 kB +0.32% 16.42 kB 16.47 kB
oss-stable-semver/react-dom/umd/react-dom.development.js +0.20% 1,118.57 kB 1,120.83 kB +0.19% 240.88 kB 241.34 kB
oss-stable/react-dom/umd/react-dom.development.js +0.20% 1,118.59 kB 1,120.86 kB +0.19% 240.91 kB 241.37 kB

Generated by 🚫 dangerJS against 2180e90

kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.188
e81e1f2 
ghstack-source-id: 5c359b97cc0a2587cf55ff879c863415a2c13127
Pull Request resolved: #25423
@kassens kassens closed this in 9813ede Oct 4, 2022
@kassens kassens deleted the gh/kassens/2/head branch October 4, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @sizebot @gaearon @facebook-github-bot