[ESLint] Preserve optional chains in declared dependencies #25932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
react-hooks/exhaustive-deps
lint rule currently strips?.
from declared dependencies (when it has a reason to rewrite them), which can turn a valid dependency into one that throws when evaluated. The issue is broader than what's fixed here (see e.g. #23248) and a comprehensive fix would require something closer to type analysis (with some notion of type guards / refinement).This PR is narrow in scope and fixes the case where:
This is done by recording the optional chaining information while visiting the declared dependencies, instead of discarding it.
I'm not deeply familiar with the code for this lint rule, but reading #19275 and in particular this comment leads me to believe this fix is safe and correct:
react/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
Lines 865 to 868 in 81d4ee9
How did you test this change?
Added a regression test and updated existing tests (some error messages were superficially changed).