Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flight Fixture to "use client" instead of .client.js #26118

Merged
merged 13 commits into from
Feb 7, 2023
Merged

Update Flight Fixture to "use client" instead of .client.js #26118

merged 13 commits into from
Feb 7, 2023

Commits on Feb 7, 2023

  1. Fix browser fixture

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4483b79 View commit details
    Browse the repository at this point in the history

  2. Drop react-fetch

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9acb2ba View commit details
    Browse the repository at this point in the history

  3. Fix typo in loader

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1a4d72d View commit details
    Browse the repository at this point in the history

  4. Support newer ESM loader format in Node

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    af65ab9 View commit details
    Browse the repository at this point in the history

  5. Remove .client.js and .server.js convention from bundles 

    We don't use this anymore since we don't export any .server.js files.
    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4e0460c View commit details
    Browse the repository at this point in the history

  6. Add "use client" to Flight fixtures

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ac03eb1 View commit details
    Browse the repository at this point in the history

  7. Remove .server.js enforcement 

    We no longer enforce this file name convention since server files are
implicit by context.
    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c26a370 View commit details
    Browse the repository at this point in the history

  8. Rename fixture .server.js to just .js

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    377da22 View commit details
    Browse the repository at this point in the history

  9. Move Node register to check for the "use client" directive 

    This removes the outdated .client.js convention from the Node register.

This is just a prototype so we don't have a proper parser. We should use
the acorn parser here instead to parse out comments etc.
    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    fb9efe3 View commit details
    Browse the repository at this point in the history

  10. Move ESM loader to parse for "use client" instead

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    bdca039 View commit details
    Browse the repository at this point in the history

  11. Properly parse the source to ensure the "use client" isn't a comment 

    or in the wrong place.
    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    68548ef View commit details
    Browse the repository at this point in the history

  12. Rename fixture files from .client.js

    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0d207a6 View commit details
    Browse the repository at this point in the history

  13. Include all .js files in the client manifest 

    This is not going to fly for any serious implementation. It pretty much
has to do a pre-compile pass over the server graph to discover the files
to include.

This is enough to run our fixture though.
    @sebmarkbage
    sebmarkbage committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1720d99 View commit details
    Browse the repository at this point in the history