Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining CommonJS imports after Rollup upgrade #26473

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fix remaining CommonJS imports after Rollup upgrade #26473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/rollup/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,16 @@ let getRollupInteropValue = id => {
// Specifying `interop: 'default'` instead will have Rollup use the imported variable as-is,
// without adding a `.default` to the reference.
const modulesWithCommonJsExports = [
'JSResourceReferenceImpl',
'error-stack-parser',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved these alphabetically.

'art/core/transform',
'art/modes/current',
'art/modes/fast-noSideEffects',
'art/modes/svg',
'JSResourceReferenceImpl',
'error-stack-parser',
'neo-async',
'webpack/lib/dependencies/ModuleDependency',
'webpack/lib/dependencies/NullDependency',
'webpack/lib/Template',
];

if (modulesWithCommonJsExports.includes(id)) {
Expand Down