Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DOM special cases per tags including controlled fields #26501

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Refactor DOM special cases per tags including controlled fields #26501

merged 5 commits into from
Mar 29, 2023

Commits on Mar 29, 2023

  1. Extract setting properties into a helper whether it's initial or update

    @sebmarkbage
    sebmarkbage committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    71a692f View commit details
    Browse the repository at this point in the history

  2. Move special cases to commit phase and inline getHostProps

    @sebmarkbage
    sebmarkbage committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    d741e00 View commit details
    Browse the repository at this point in the history

  3. Ensure check is a boolean (function/symbol are false)

    @sebmarkbage
    sebmarkbage committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    e4aeee8 View commit details
    Browse the repository at this point in the history

  4. Remove force commit phase 

    This isn't necessary because we always call "updateWrapper" after the event handling.

We can't rely on even getting here if no props have changed since we could've bailed on the props object alone before getting here.
    @sebmarkbage
    sebmarkbage committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    9c3ef63 View commit details
    Browse the repository at this point in the history

  5. Unify switches when hydrating 

    We don't really do anything between init and post mount, other than
scheduling for later. So there's no behavior difference.
    @sebmarkbage
    sebmarkbage committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    08de5b1 View commit details
    Browse the repository at this point in the history