Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff properties in the commit phase instead of generating an update payload #26583

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Diff properties in the commit phase instead of generating an update payload #26583

merged 4 commits into from
Apr 10, 2023

Commits on Apr 10, 2023

  1. Add flag

    @sebmarkbage
    sebmarkbage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    594b4b0 View commit details
    Browse the repository at this point in the history

  2. Diff properties in the commit phase instead of generating an update p… 

    …ayload

This removes the concept of prepareUpdate().

React Native already does everything in the commit phase, but generates
a temporary update payload before applying it.

React Fabric does it both in the render phase. Now it just moves it to a
single host config.

For DOM I forked updateProperties into one that does diffing and updating
in one pass vs just applying a pre-diffed updatePayload.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    c09d9b3 View commit details
    Browse the repository at this point in the history

  3. Diff styles instead of always writing the full set 

    Also fixes a bug where styles weren't cleared on custom elements.
    @sebmarkbage
    sebmarkbage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d629f8b View commit details
    Browse the repository at this point in the history

  4. Add warning if is is set and tries to update

    @sebmarkbage
    sebmarkbage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d74688c View commit details
    Browse the repository at this point in the history