[Fizz] Move formatContext tracking back to the task #27325

sebmarkbage · 2023-09-01T15:38:29Z

In #21113 I moved this over to the segment from the task. This partially reverts this two use two fields instead. I was just trying to micro-optimize by reusing a single field.

This is really conceptually two different values. Task is keeping track of the working state of the currently executing context.

The segment just needs to keep track of which parent context it was created in so that it can be wrapped correctly when a segment is written. We just happened to rely on the working state returning to the top before completing.

The main motivation is that there is no segment for replaying.

This is really conceptually two different values. Task is keeping track of the working state of the currently executing context. The segment just needs to keep track of which parent context it was created in so that it can be wrapped correctly when a segment is written. We just happened to rely on the working state returning to the top before completing.

react-sizebot · 2023-09-01T15:44:33Z

Comparing: 7022e8d...20e0d8b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	165.63 kB	165.63 kB	=	51.88 kB	51.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	174.70 kB	174.70 kB	=	54.61 kB	54.61 kB
facebook-www/ReactDOM-prod.classic.js	=	570.44 kB	570.44 kB	=	100.45 kB	100.45 kB
facebook-www/ReactDOM-prod.modern.js	=	554.21 kB	554.21 kB	=	97.61 kB	97.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 20e0d8b

In facebook#21113 I moved this over to the segment from the task. This partially reverts this two use two fields instead. I was just trying to micro-optimize by reusing a single field. This is really conceptually two different values. Task is keeping track of the working state of the currently executing context. The segment just needs to keep track of which parent context it was created in so that it can be wrapped correctly when a segment is written. We just happened to rely on the working state returning to the top before completing. The main motivation is that there is no `segment` for replaying.

In #21113 I moved this over to the segment from the task. This partially reverts this two use two fields instead. I was just trying to micro-optimize by reusing a single field. This is really conceptually two different values. Task is keeping track of the working state of the currently executing context. The segment just needs to keep track of which parent context it was created in so that it can be wrapped correctly when a segment is written. We just happened to rely on the working state returning to the top before completing. The main motivation is that there is no `segment` for replaying. DiffTrain build for commit 3cc8a93.

sebmarkbage requested review from gnoff and acdlite September 1, 2023 15:38

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 1, 2023

sebmarkbage changed the title ~~Move formatContext tracking back to the task~~ [Fizz] Move formatContext tracking back to the task Sep 1, 2023

acdlite approved these changes Sep 5, 2023

View reviewed changes

sebmarkbage merged commit 3cc8a93 into facebook:main Sep 5, 2023
36 checks passed

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fizz] Move formatContext tracking back to the task #27325

[Fizz] Move formatContext tracking back to the task #27325

sebmarkbage commented Sep 1, 2023

react-sizebot commented Sep 1, 2023

[Fizz] Move formatContext tracking back to the task #27325

[Fizz] Move formatContext tracking back to the task #27325

Conversation

sebmarkbage commented Sep 1, 2023

react-sizebot commented Sep 1, 2023

Critical size changes

Significant size changes