Commits on Sep 12, 2023

1. When Float was first developed the internal implementation and extern… …

   …al interface were the same. This is problematic for a few reasons. One, the public interface is typed but it is also untrusted and we should not assume that it is actually respected. Two, the internal implementations can get called from places other than the the public interface and having to construct an options argument that ends up being destructured to process the request is computationally wasteful and may limit JIT optimizations to some degree. Lastly, the wire format was not as compressed as it could be and it was untyped.
   
   This refactor aims to address that by separating the public interface from the internal implementations so we can solve these challenges and also make it easier to change Float in the future
   
   The internal dispatcher method preinit is now preinitStyle and preinitScript.
   The internal dispatcher method preinitModule is now preinitModuleScript in anticipation of different implementations for other module types in the future
   The wire format is explicitly typed and only includes options if they are actually used omitting undefined and nulls.
   Some function arguments are not options even if they are optional. For instance precedence can be null/undefined because we deafult it to 'default' however we don't cosnider this an option because it is not something we transparently apply as props to the underlying instance.
   Fixes a problem with keying images in flight wehre srcset and sizes were not being taken into account.
   Moves argument validation into the ReactDOMFloat file where it is shared with all runtimes that expose these methods

   

   gnoff committed Sep 12, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8a780a4
   • Browse repository at this point

   Copy the full SHA

   8a780a4 View commit details

   Browse the repository at this point in the history