[Fizz][Float] Refactor StyleResource #27398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Style tag Resources. The Style tag resource was already handled with special rules because it does not Flush is the same way as other resources do. This change reimagines the precedences as a combination of a style tag rules queue and a list of stylesheets. This change eliminates a number of conditionals by embedding these variants in the data represenation itself. This change also moves the binary encoding to work time rather than flush time. Since style resources were the only type that actually used the `type` property I've removed this making resource object size slightly smaller
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
commented
Sep 20, 2023
Comment on lines
+4168
to
+4169
| // Determine if this boundary has stylesheets that need to be awaited upon completion | ||
| boundaryResources.sheets.forEach(hasStylesToHoist); |
There was a problem hiding this comment.
would be nice if Set.prototype.some existed. Would love to bail out early but not sure if using a raw iterator is slower enough in the common case (few sheets) to be worth it
|
closing as part of #27400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the implementation of stylesheet resources and style tag resources. The style tag resource was already handled with special rules because it does not Flush is the same way as other resources do. This change reimagines the precedences as a combination of a style tag rules queue and a list of stylesheets.
This change eliminates a number of conditionals by embedding these variants in the data represenation itself.
This change also moves the binary encoding to work time rather than flush time.
Since style resources were the only type that actually used the
typeproperty I've removed this making resource object size slightly smaller