[Flight] Wire up async_hooks in Node.js DEV for inspecting Promises #27840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
In the Edge build we currently get this from the global object just like AsyncLocalStorage. This is unfortunate and something we'd like to move away from.
This is a DEV only feature.
sebmarkbage
force-pushed
the
debuginfo
branch
from
9a963d8
to
2ba9670
Compare
sebmarkbage
changed the title
sebmarkbage
commented
Dec 15, 2023
| @@ -117,6 +118,8 @@ import binaryToComparableString from 'shared/binaryToComparableString'; | |||
|
|
|||
| import {SuspenseException, getSuspendedThenable} from './ReactFlightThenable'; | |||
|
|
|||
| initAsyncDebugInfo(); | |||
There was a problem hiding this comment.
The explicit init here is really only due to the module cycle between the implementation and the config since we need createAsyncHook to have been resolved already.
|
Diagnostic Channels were evaluated but they're not detailed enough to trace where something was eventually awaited and what ultimately caused what. It just tells you that it happened. |
sebmarkbage
force-pushed
the
debuginfo
branch
from
273e0ba
to
52c924e
Compare
gnoff
approved these changes
Dec 16, 2023
acdlite
added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
### React upstream changes - facebook/react#27888 - facebook/react#27870 - facebook/react#27871 - facebook/react#27850 - facebook/react#27839 - facebook/react#27842 - facebook/react#27841 - facebook/react#27840 - facebook/react#27761 - facebook/react#27831 - facebook/react#27801 Closes NEXT-2012
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…acebook#27840) This wires up the use of `async_hooks` in the Node build (as well as the Edge build when a global is available) in DEV mode only. This will be used to track debug info about what suspended during an RSC pass. Enabled behind a flag for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up the use of
async_hooksin the Node build (as well as the Edge build when a global is available) in DEV mode only. This will be used to track debug info about what suspended during an RSC pass.Enabled behind a flag for now.