Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] strict effect tests should fail #28104

Closed
wants to merge 1 commit into from

Conversation

rickhanlonii
Copy link
Member

While doing https://github.com/facebook/react/pull/28102/files, I suspect these strict effect tests were not running. Creating a PR to run all the tests and hopefully some fail and I'm just missing something.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024
@react-sizebot
Copy link

Comparing: c7e735f...e6f5ee4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.34 kB 176.34 kB = 54.93 kB 54.93 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.44 kB 178.44 kB = 55.57 kB 55.57 kB
facebook-www/ReactDOM-prod.classic.js = 572.79 kB 572.79 kB = 100.80 kB 100.80 kB
facebook-www/ReactDOM-prod.modern.js = 556.55 kB 556.55 kB = 97.88 kB 97.88 kB
test_utils/ReactAllWarnings.js Deleted 67.55 kB 0.00 kB Deleted 16.54 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.55 kB 0.00 kB Deleted 16.54 kB 0.00 kB

Generated by 🚫 dangerJS against e6f5ee4

@rickhanlonii
Copy link
Member Author

rickhanlonii commented Jan 26, 2024

Yeah, these tests haven't run for a year, since #25575.

This is fixed by #28102, which removes the flag and updates the tests to use StrictMode directly, instead of implicitly relying on this flag being a variant.

cc @kassens

@rickhanlonii rickhanlonii deleted the rh/test-effects branch January 26, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants