Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-dom] move all client code to react-dom/client #28271

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[react-dom] move all client code to react-dom/client #28271

merged 2 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Move client only exports to react-dom/client 

    This change updates the entrypoints for `react-dom` to only include exports which make sense in every runtime (Flight, Fizz, and Fiber). The main benefit to doing this is we stop including the entire client build when importing anything from `react-dom`. The server-rendering-stub was added as a manual way of doing this prior to the next major and now that stub simply reexports from `react-dom`. In a future major we will remove the stub altogether.

This change affects the OSS channels but does not update how the meta entrypoints are organized
    @gnoff
    gnoff committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4ac97cc View commit details
    Browse the repository at this point in the history

  2. Now that react-dom/client is a separate build there are additional in… 

    …ternal module boundaries that get picked up by devtoools timeline testing. This udpates snapshots to reflect this expected change.
    @gnoff
    gnoff committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    223ea80 View commit details
    Browse the repository at this point in the history