Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate legacy mode test in ReactDOMSingletonComponents #28339

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Annotate legacy mode test in ReactDOMSingletonComponents #28339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-dom/src/__tests__/ReactDOMSingletonComponents-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,17 +996,17 @@ describe('ReactDOM HostSingleton', () => {
});

// https://github.com/facebook/react/issues/26128
it('(#26128) does not throw when rendering at body', async () => {
it('(#26128) does not throw when rendering at body in legacy mode', async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We warn for this in the new root:

react/packages/react-dom/src/__tests__/ReactDOMRoot-test.js

Line 224 in 015ff2e

it('warns if creating a root on the document.body', async () => {

ReactDOM.render(<div />, document.body);
});

// https://github.com/facebook/react/issues/26128
it('(#26128) does not throw when rendering at <html>', async () => {
it('(#26128) does not throw when rendering at <html> in legacy mode', async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell we only have tests for hydrating into <html>

ReactDOM.render(<body />, document.documentElement);
});

// https://github.com/facebook/react/issues/26128
it('(#26128) does not throw when rendering at document', async () => {
it('(#26128) does not throw when rendering at document in legacy mode', async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We disallow this at the type level but have no runtime warning

ReactDOM.render(<html />, document);
});
});