Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic enableComponentStackLocations Flag for React Native (FB) #28400

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

yungsters
Copy link
Contributor

@yungsters yungsters commented Feb 20, 2024

Summary

Changes the enableComponentStackLocations feature flag to be dynamic for React Native (FB), so that it can be evaluated for compatibility before eventually being enabled for React Native.

How did you test this change?

I'll be importing this PR to test it.

@react-sizebot
Copy link

Comparing: 3b26000...d7358c5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.87 kB 176.87 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.97 kB 178.97 kB = 55.77 kB 55.77 kB
facebook-www/ReactDOM-prod.classic.js = 591.94 kB 591.94 kB = 104.47 kB 104.47 kB
facebook-www/ReactDOM-prod.modern.js = 575.23 kB 575.23 kB = 101.48 kB 101.48 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +35.04% 40.04 kB 54.08 kB +33.90% 10.52 kB 14.08 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +33.85% 41.45 kB 55.49 kB +32.56% 10.91 kB 14.46 kB
facebook-react-native/react/cjs/React-dev.js +12.18% 114.96 kB 128.96 kB +13.00% 27.32 kB 30.88 kB
test_utils/ReactAllWarnings.js Deleted 67.04 kB 0.00 kB Deleted 16.43 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +35.04% 40.04 kB 54.08 kB +33.90% 10.52 kB 14.08 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +33.85% 41.45 kB 55.49 kB +32.56% 10.91 kB 14.46 kB
facebook-react-native/react/cjs/React-dev.js +12.18% 114.96 kB 128.96 kB +13.00% 27.32 kB 30.88 kB
react-native/implementations/ReactFabric-prod.fb.js +1.50% 329.17 kB 334.10 kB +1.87% 58.28 kB 59.37 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +1.46% 336.77 kB 341.70 kB +1.77% 59.65 kB 60.71 kB
react-native/implementations/ReactFabric-profiling.fb.js +1.38% 356.34 kB 361.28 kB +1.71% 62.48 kB 63.55 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +1.36% 363.98 kB 368.92 kB +1.65% 63.88 kB 64.93 kB
react-native/implementations/ReactFabric-dev.fb.js +1.08% 1,000.37 kB 1,011.13 kB +1.41% 200.52 kB 203.36 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +1.06% 1,014.98 kB 1,025.74 kB +1.39% 204.25 kB 207.09 kB
test_utils/ReactAllWarnings.js Deleted 67.04 kB 0.00 kB Deleted 16.43 kB 0.00 kB

Generated by 🚫 dangerJS against d7358c5

@yungsters yungsters changed the title Dynamic enableComponenStackLocations Flag for React Native (FB) Dynamic enableComponentStackLocations Flag for React Native (FB) Feb 20, 2024
@yungsters yungsters merged commit 25dbb35 into facebook:main Feb 22, 2024
35 of 36 checks passed
@yungsters yungsters deleted the react-native branch February 22, 2024 23:40
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…acebook#28400)

## Summary

Changes the `enableComponentStackLocations` feature flag to be dynamic
for React Native (FB), so that it can be evaluated for compatibility
before eventually being enabled for React Native.

## How did you test this change?

I'll be importing this PR to test it.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…28400)

## Summary

Changes the `enableComponentStackLocations` feature flag to be dynamic
for React Native (FB), so that it can be evaluated for compatibility
before eventually being enabled for React Native.

## How did you test this change?

I'll be importing this PR to test it.

DiffTrain build for commit 25dbb35.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants