Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[be] Remove unused, experimental getCacheSignal API #28706

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[be] Remove unused, experimental getCacheSignal API #28706

merged 2 commits into from
Apr 2, 2024

Conversation

josephsavona
Copy link
Contributor

Similar to #28698, this removes the unstable_getCacheSignal() API since we don't intend to ship this to stable.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 1, 2024
@josephsavona josephsavona requested a review from gnoff April 1, 2024 19:34
josephsavona
josephsavona commented Apr 1, 2024
View reviewed changes
packages/react/src/ReactFetch.js
if (
options &&
options.signal &&
options.signal !== dispatcher.getCacheSignal()
Copy link
Contributor Author

@josephsavona josephsavona Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that maybe someone (Next?) is passing the signal returned from getCacheSignal() back to React. But since getCacheSignal isn't exposed, we should be able to just not do that?

@gnoff is this change cool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed offline that Next is not using this API, so it's safe to remove this

@react-sizebot
Copy link

react-sizebot commented Apr 1, 2024 •
edited
Loading

Comparing: 48ec17b...084402b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.99 kB 176.93 kB = 55.01 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.85 kB 172.79 kB = 53.90 kB 53.88 kB
facebook-www/ReactDOM-prod.classic.js = 591.27 kB 591.17 kB = 103.75 kB 103.72 kB
facebook-www/ReactDOM-prod.modern.js = 573.01 kB 572.91 kB = 100.80 kB 100.77 kB
oss-experimental/react/cjs/react.production.js = 41.46 kB 40.60 kB = 11.42 kB 11.12 kB
oss-experimental/react/cjs/react.react-server.production.js = 40.86 kB 40.01 kB = 11.99 kB 11.73 kB
oss-experimental/react/cjs/react.production.min.js = 9.89 kB 9.66 kB = 3.65 kB 3.56 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 0.79 kB 0.69 kB = 0.52 kB 0.47 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 0.79 kB 0.69 kB = 0.52 kB 0.47 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 0.79 kB 0.69 kB = 0.52 kB 0.47 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 141.80 kB 141.50 kB = 32.28 kB 32.21 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 139.51 kB 139.21 kB = 31.65 kB 31.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 139.16 kB 138.86 kB = 31.43 kB 31.37 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 136.92 kB 136.62 kB = 31.33 kB 31.27 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 136.87 kB 136.57 kB = 30.84 kB 30.77 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 135.87 kB 135.57 kB = 31.02 kB 30.96 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 134.99 kB 134.69 kB = 30.82 kB 30.76 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 133.42 kB 133.12 kB = 30.34 kB 30.27 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 143.21 kB 142.88 kB = 31.45 kB 31.39 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 130.71 kB 130.41 kB = 29.77 kB 29.71 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js = 140.64 kB 140.31 kB = 30.76 kB 30.70 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 120.11 kB 119.81 kB = 27.96 kB 27.90 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 120.11 kB 119.81 kB = 27.96 kB 27.90 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 116.77 kB 116.48 kB = 27.26 kB 27.20 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 117.83 kB 117.53 kB = 27.34 kB 27.28 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 117.83 kB 117.53 kB = 27.34 kB 27.28 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 114.70 kB 114.41 kB = 26.71 kB 26.65 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 117.48 kB 117.18 kB = 27.06 kB 27.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 117.48 kB 117.18 kB = 27.06 kB 27.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 114.11 kB 113.82 kB = 26.37 kB 26.31 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 115.19 kB 114.89 kB = 26.50 kB 26.45 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 115.19 kB 114.89 kB = 26.50 kB 26.45 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js = 112.04 kB 111.74 kB = 25.87 kB 25.81 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 114.76 kB 114.46 kB = 26.87 kB 26.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 114.76 kB 114.46 kB = 26.87 kB 26.81 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 111.59 kB 111.29 kB = 26.31 kB 26.25 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 114.39 kB 114.08 kB = 26.79 kB 26.73 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 114.39 kB 114.08 kB = 26.79 kB 26.73 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 111.27 kB 110.97 kB = 26.24 kB 26.18 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 109.86 kB 109.57 kB = 25.87 kB 25.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 112.83 kB 112.53 kB = 26.36 kB 26.30 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 112.83 kB 112.53 kB = 26.36 kB 26.30 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 109.02 kB 108.72 kB = 25.64 kB 25.58 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 111.94 kB 111.64 kB = 26.12 kB 26.06 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 111.94 kB 111.64 kB = 26.12 kB 26.06 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 120.71 kB 120.38 kB = 27.13 kB 27.07 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js = 120.71 kB 120.38 kB = 27.13 kB 27.07 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.61 kB 106.32 kB = 25.07 kB 25.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.61 kB 106.32 kB = 25.07 kB 25.01 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js = 118.14 kB 117.81 kB = 26.46 kB 26.40 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js = 118.14 kB 117.81 kB = 26.46 kB 26.40 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 109.03 kB 108.72 kB = 25.54 kB 25.49 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 109.03 kB 108.72 kB = 25.54 kB 25.49 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 105.89 kB 105.59 kB = 24.87 kB 24.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 104.54 kB 104.25 kB = 24.52 kB 24.47 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 104.54 kB 104.25 kB = 24.52 kB 24.47 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 103.96 kB 103.66 kB = 24.17 kB 24.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 103.96 kB 103.66 kB = 24.17 kB 24.12 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js = 101.88 kB 101.58 kB = 23.68 kB 23.63 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js = 101.88 kB 101.58 kB = 23.68 kB 23.63 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 100.98 kB 100.68 kB = 23.94 kB 23.88 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 100.98 kB 100.68 kB = 23.94 kB 23.88 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 100.66 kB 100.36 kB = 23.88 kB 23.82 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 100.66 kB 100.36 kB = 23.88 kB 23.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.25 kB 98.96 kB = 23.50 kB 23.45 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.25 kB 98.96 kB = 23.50 kB 23.45 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 98.41 kB 98.11 kB = 23.28 kB 23.22 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 98.41 kB 98.11 kB = 23.28 kB 23.22 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.73 kB 95.43 kB = 22.70 kB 22.65 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.73 kB 95.43 kB = 22.70 kB 22.65 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 93.41 kB 93.10 kB = 21.25 kB 21.19 kB
facebook-www/ReactFlightDOMServer-dev.modern.js = 101.73 kB 101.38 kB = 21.22 kB 21.16 kB
oss-stable/react/cjs/react.react-server.production.min.js = 8.04 kB 8.00 kB = 3.30 kB 3.29 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js = 8.01 kB 7.98 kB = 3.27 kB 3.26 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 72.60 kB 72.30 kB = 17.29 kB 17.24 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 72.60 kB 72.30 kB = 17.29 kB 17.24 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 69.48 kB 69.18 kB = 16.62 kB 16.56 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.js = 59.55 kB 59.25 kB = 14.52 kB 14.47 kB
oss-stable/react-server/cjs/react-server-flight.production.js = 59.55 kB 59.25 kB = 14.52 kB 14.47 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js = 33.07 kB 32.90 kB = 10.73 kB 10.66 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js = 32.56 kB 32.39 kB = 10.55 kB 10.48 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js = 32.48 kB 32.32 kB = 10.55 kB 10.48 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js = 31.99 kB 31.82 kB = 10.40 kB 10.33 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js = 31.68 kB 31.51 kB = 10.22 kB 10.16 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js = 31.36 kB 31.19 kB = 10.19 kB 10.14 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js = 31.27 kB 31.10 kB = 10.12 kB 10.06 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js = 31.26 kB 31.09 kB = 10.08 kB 10.02 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js = 30.84 kB 30.68 kB = 10.05 kB 9.99 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js = 30.73 kB 30.57 kB = 9.96 kB 9.89 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js = 30.56 kB 30.39 kB = 10.03 kB 9.97 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js = 30.56 kB 30.39 kB = 10.03 kB 9.97 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js = 30.05 kB 29.88 kB = 9.88 kB 9.82 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js = 30.05 kB 29.88 kB = 9.88 kB 9.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js = 29.97 kB 29.81 kB = 9.88 kB 9.82 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js = 29.97 kB 29.81 kB = 9.88 kB 9.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js = 29.48 kB 29.31 kB = 9.73 kB 9.67 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js = 29.48 kB 29.31 kB = 9.73 kB 9.67 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js = 29.45 kB 29.28 kB = 9.97 kB 9.91 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js = 29.09 kB 28.93 kB = 9.53 kB 9.47 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js = 29.09 kB 28.93 kB = 9.53 kB 9.47 kB
facebook-www/ReactFlightDOMServer-prod.modern.js = 39.62 kB 39.39 kB = 9.01 kB 8.96 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js = 28.69 kB 28.53 kB = 9.40 kB 9.34 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js = 28.69 kB 28.53 kB = 9.40 kB 9.34 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js = 28.69 kB 28.52 kB = 9.43 kB 9.37 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js = 28.69 kB 28.52 kB = 9.43 kB 9.37 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js = 28.80 kB 28.63 kB = 9.51 kB 9.44 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js = 28.80 kB 28.63 kB = 9.51 kB 9.44 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js = 28.17 kB 28.00 kB = 9.27 kB 9.21 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js = 28.17 kB 28.00 kB = 9.27 kB 9.21 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js = 28.28 kB 28.11 kB = 9.38 kB 9.30 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js = 28.28 kB 28.11 kB = 9.38 kB 9.30 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js = 26.94 kB 26.77 kB = 9.31 kB 9.25 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js = 26.94 kB 26.77 kB = 9.31 kB 9.25 kB
oss-experimental/react/umd/react.development.js = 123.55 kB 122.67 kB = 31.80 kB 31.52 kB
facebook-www/React-dev.classic.js = 127.32 kB 126.37 kB = 29.99 kB 29.72 kB
facebook-www/React-dev.modern.js = 127.25 kB 126.31 kB = 29.97 kB 29.71 kB
facebook-react-native/react/cjs/React-dev.js = 125.39 kB 124.44 kB = 29.61 kB 29.32 kB
oss-experimental/react/cjs/react.development.js = 100.93 kB 100.08 kB = 27.22 kB 26.93 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js = 18.83 kB 18.67 kB = 6.75 kB 6.69 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.min.js = 16.38 kB 16.21 kB = 6.08 kB 6.00 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js = 16.38 kB 16.21 kB = 6.08 kB 6.00 kB
oss-experimental/react/cjs/react.react-server.development.js = 83.15 kB 82.23 kB = 23.31 kB 23.00 kB
oss-experimental/react/umd/react.production.min.js = 13.44 kB 13.22 kB = 5.12 kB 5.03 kB
oss-experimental/react/umd/react.profiling.min.js = 13.44 kB 13.21 kB = 5.12 kB 5.03 kB
facebook-www/React-profiling.classic.js = 21.83 kB 21.44 kB = 5.43 kB 5.32 kB
facebook-www/React-profiling.modern.js = 21.70 kB 21.32 kB = 5.40 kB 5.29 kB
facebook-www/React-prod.classic.js = 21.39 kB 21.01 kB = 5.35 kB 5.24 kB
facebook-react-native/react/cjs/React-profiling.js = 21.34 kB 20.96 kB = 5.34 kB 5.22 kB
facebook-www/React-prod.modern.js = 21.26 kB 20.88 kB = 5.33 kB 5.21 kB
facebook-react-native/react/cjs/React-prod.js = 21.03 kB 20.65 kB = 5.29 kB 5.18 kB
oss-experimental/react/cjs/react.react-server.production.min.js = 10.08 kB 9.89 kB = 3.99 kB 3.92 kB
oss-experimental/react/cjs/react.production.js = 41.46 kB 40.60 kB = 11.42 kB 11.12 kB
oss-experimental/react/cjs/react.react-server.production.js = 40.86 kB 40.01 kB = 11.99 kB 11.73 kB
oss-experimental/react/cjs/react.production.min.js = 9.89 kB 9.66 kB = 3.65 kB 3.56 kB
oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 0.79 kB 0.69 kB = 0.52 kB 0.47 kB
oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 0.79 kB 0.69 kB = 0.52 kB 0.47 kB
oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js = 0.79 kB 0.69 kB = 0.52 kB 0.47 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 084402b

kassens
kassens approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of tests need cleanup as well.

@josephsavona josephsavona force-pushed the cleanup-getCacheSignal-api branch from d565221 to 084402b Compare April 2, 2024 17:32
@josephsavona
Copy link
Contributor Author

All cleaned up, landing

@josephsavona josephsavona merged commit 8cb6a1c into facebook:main Apr 2, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
@josephsavona
[be] Remove unused, experimental getCacheSignal API (#28706)
8a319a6 
Similar to #28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.

DiffTrain build for [8cb6a1c](8cb6a1c)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@josephsavona @AndyPengc12
[be] Remove unused, experimental getCacheSignal API (facebook#28706)
64397e2 
Similar to facebook#28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@josephsavona
[be] Remove unused, experimental getCacheSignal API (#28706)
94f98fd 
Similar to #28698, this removes the `unstable_getCacheSignal()` API
since we don't intend to ship this to stable.

DiffTrain build for commit 8cb6a1c.
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephsavona @react-sizebot @kassens @facebook-github-bot