Lazily freeze in case anything in the currently initializing chunk is blocked #29139
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 3f1436c...9304ef9 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
| initializingChunkBlockedModel.deps > 0 | ||
| ) { | ||
| const freeze = Object.freeze.bind(Object, element.props); | ||
| initializingChunk.then(freeze, freeze); |
There was a problem hiding this comment.
Q: is there a possibility that this callback would run before a createModelResolver callback, in which case we'd still try to mutate a frozen object? or is the inside-out traversal order of the JSON reviver protecting us from that
There was a problem hiding this comment.
This waits until the entire chunk that was being parsed is resolved which means that everything inside it has to be initialized already. Otherwise other user spaces listeners could observer the intermediate state.
However, this does mean that an early listener to this chunk can observe it before we freeze it. Which is actually quite likely since initialization happens lazily in the first place. If that listener is the typical case of React listening then it's just a ping to schedule a rerender and the rerender happens after. You could listen yourself but this is an edge case that you need to wait for the blocked model in the first place and it's dev only and you might end up hitting the freeze later if you do something similar anyway.
| Object.freeze(element.props); | ||
| if ( | ||
| initializingChunkBlockedModel !== null && | ||
| initializingChunkBlockedModel.deps > 0 |
There was a problem hiding this comment.
Since a cycle doesn't increase this dependency I'm not sure if a cycle that is in the props object itself would fail here. Maybe I'll just remove the deps check.
Fixed #29129.