Fix ReactJSXElementValidator tests

[eps1lon]

Summary

Noticed in #29088 that some of these test assertions rely on the fact that Component does not handle children. This is likely a bug with the test since you wouldn't write components like this. Static type-checking would reject <Component>{children}</Component> when Component doesn't implement handling of children.

How did you test this change?

• yarn test --watch packages/react/src/__tests__/ReactJSXElementValidator-test.js

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 21, 2024 10:13am

[react-sizebot]

Comparing: 6f90365...80a8cea

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.66 kB	6.66 kB	=	1.82 kB	1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	495.71 kB	495.71 kB	=	88.78 kB	88.78 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.67 kB	6.67 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	500.51 kB	500.51 kB	=	89.47 kB	89.47 kB
facebook-www/ReactDOM-prod.classic.js	=	592.86 kB	592.86 kB	=	104.28 kB	104.28 kB
facebook-www/ReactDOM-prod.modern.js	=	569.08 kB	569.08 kB	=	100.70 kB	100.70 kB
test_utils/ReactAllWarnings.js	Deleted	64.35 kB	0.00 kB	Deleted	16.05 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	64.35 kB	0.00 kB	Deleted	16.05 kB	0.00 kB

Generated by 🚫 dangerJS against 80a8cea

[Brandon-Isaac]

And I thought I knew react, this is fascinating

[sebmarkbage]

I think it's still important that we assert that this code is skipped under the condition.

https://github.com/facebook/react/blob/main/packages/react/src/jsx/ReactJSXElement.js#L1103

#29088 (comment)