[Flight] Add failing test for dedupe resolution on blocked models #29200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by vercel/next.js#66033 I was suspecting that the bug was introduced with facebook#28996, but I could not make the test succeed on a commit before that PR, so maybe this assumption is wrong.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 5cc9f69...00af602 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
lubieowoce
reviewed
May 21, 2024
| @@ -247,6 +247,55 @@ describe('ReactFlightDOMBrowser', () => { | |||
| expect(container.innerHTML).toBe('<span>Hello, World!</span>'); | |||
| }); | |||
|
|
|||
| it('should resolve deduped objects within the same model root when it is blocked', async () => { | |||
There was a problem hiding this comment.
maybe do
Suggested change
| it('should resolve deduped objects within the same model root when it is blocked', async () => { | |
| it.failing('should resolve deduped objects within the same model root when it is blocked', async () => { |
so that it passes CI?
There was a problem hiding this comment.
I tried that already in #29129, but the Jest setup in the React repo does not seem to support this.
sebmarkbage
added a commit
that referenced
this pull request
May 21, 2024
…locked state (#29201) Fixes #29200 The cyclic state might have added listeners that will still need to be invoked. This happens if we have a cyclic reference AND end up blocked. We have already cleared these before entering the parsing when we enter the CYCLIC state so we they already have the right type. If listeners are added during this phase they should carry over to the blocked state. --------- Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by vercel/next.js#66033
I was suspecting that the bug was introduced with #28996, but I could not make the test succeed on a commit before that PR, so maybe this assumption (or the reproduction) is wrong.EDIT: With a revert of #28996, the test does succeed.