[compiler:babel] Don't read config files when not running as part of #29211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
poteto
added a commit
that referenced
this pull request
May 22, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config ghstack-source-id: 88a3958db2c6332167c00c9413645b1d14d848f4 Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 22, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 88a3958db2c6332167c00c9413645b1d14d848f4 Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 22, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 5df2597983a0554d4c6698fe59a91ba8bd3f8e10 Pull Request resolved: #29211
|
Comparing: a9a0106...8e5d071 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
approved these changes
May 22, 2024
This was referenced May 22, 2024
poteto
added a commit
that referenced
this pull request
May 22, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: f0fa887568c55a79b3dd9bd3f9bc0a4739c5aec0 Pull Request resolved: #29211
Ayc0
reviewed
May 23, 2024
compiler/packages/babel-plugin-react-compiler/src/Babel/RunReactCompilerBabelPlugin.ts
Show resolved
Hide resolved
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 1d9b7af02057718db9643c83f73ce827ab6ee40e Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 86daa0bc2390e02682675bc2fccb0bd83b64b7ac Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 5c3cb02f3254e0ccaf075ab5a3cd8b32714a1573 Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 5c3cb02f3254e0ccaf075ab5a3cd8b32714a1573 Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 5c3cb02f3254e0ccaf075ab5a3cd8b32714a1573 Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: d6fdc43c5c9107645f36718203873aa3f6228475 Pull Request resolved: #29211
poteto
added a commit
that referenced
this pull request
May 29, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: d6fdc43c5c9107645f36718203873aa3f6228475 Pull Request resolved: #29211
lakshmiji-jio
pushed a commit
to lakshmiji-jio/lakshmiji-react
that referenced
this pull request
Jun 1, 2024
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: 92b193508e7ce2951e487757b3bcad0a273f9e26 Pull Request resolved: facebook/react#29211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
user's pipeline
When the user app has a babel.config file that is missing the compiler,
strange things happen as babel does some strange merging of options from
the user's config and in various callsites like in our eslint rule and
healthcheck script. To minimize odd behavior, we default to not reading
the user's babel.config
Fixes #29135