Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber] Enable Native console.createTask Stacks When Available #29223

Merged
merged 3 commits into from
May 26, 2024

Commits on May 25, 2024

  1. Disable owner stacks from console.error when createTask is available

    We rely on the native stack when console.createTask is available in the runtime.
    sebmarkbage committed May 25, 2024
    Configuration menu
    Copy the full SHA
    91b10c0 View commit details
    Browse the repository at this point in the history
  2. Run debug context in the console Task of the fiber

    This creates a native "owner stack" for the execution context. Any JSX
    created within this context will get new tasks created continuing the stack.
    sebmarkbage committed May 25, 2024
    Configuration menu
    Copy the full SHA
    e347e83 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Don't append Component Stack in React DevTools if we already have a n…

    …ative task
    
    If the current Fiber already has a native task, then it might be in a native async task and so we already have a component stack.
    
    If it doesn't have a native task, it's because this is not DEV mode or it's an older React or React didn't detect console.createTask.
    sebmarkbage committed May 26, 2024
    Configuration menu
    Copy the full SHA
    5adda9c View commit details
    Browse the repository at this point in the history