-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix<compiler>: reread the testfilter file if filter enabled during the watch process #29775
fix<compiler>: reread the testfilter file if filter enabled during the watch process #29775
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: 704aeed...9066b7c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could cause race conditions (if you hit f multiple times and the filter read happens to be slow) but technically we already can hit this condition, so this should be fine.
Oh, I get it! 👍 |
Summary
Resolve #29720
In the above PR, I overlooked that we can change the filter mode during the watch process. Now it's fixed.
How did you test this change?
2024-06-06.09.38.19.mov