Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: revert #29720 to unbreak filter mode in snap #29780

Closed
wants to merge 4 commits into from
Closed

compiler: revert #29720 to unbreak filter mode in snap #29780

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0197aca
compiler: revert #29720 to unbreak filter mode in snap
josephsavona Jun 6, 2024
94e2e5e
Update on "compiler: revert #29720 to unbreak filter mode in snap"
josephsavona Jun 6, 2024
88b9e8c
Update on "compiler: revert #29720 to unbreak filter mode in snap"
josephsavona Jun 6, 2024
59bc1b7
Update on "compiler: revert #29720 to unbreak filter mode in snap"
josephsavona Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/packages/snap/src/runner-watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ function subscribeFilterFile(
} else if (
events.findIndex((event) => event.path.includes(FILTER_FILENAME)) !== -1
) {
state.filter = await readTestFilter();
if (state.mode.filter) {
state.filter = await readTestFilter();
state.mode.action = RunnerAction.Test;
onChange(state);
}
Expand Down Expand Up @@ -219,7 +219,7 @@ export async function makeWatchRunner(
action: RunnerAction.Test,
filter: filterMode,
},
filter: filterMode ? await readTestFilter() : null,
filter: await readTestFilter(),
};

subscribeTsc(state, onChange);
Expand Down