-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Enable sourceMaps in tsconfig #30064
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: 7608516...cbe43c3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind seeing if you can add this option to the virtual tsconfig instead?: https://github.com/facebook/react/blob/main/compiler/packages/snap/src/runner-watch.ts#L30
The downside of changing tsconfig directly is that it affects our build and generates extra files that will be included in npm. And if we can help it I'd rather not have any source maps in there because it's unnecessary for a build-time only module plus bloats the package size a bit.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!! 🤍🤍🤍
With this, we can set a
debugger
breakpoint and we'll break into the source code when running tests with snap. Without this, we'd break into the transpiled js code.