Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: unfork prettier config #30205

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Compiler: unfork prettier config #30205

merged 3 commits into from
Jul 18, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Jul 3, 2024

Updates the prettier config to format all .ts and .tsx files in the repo using the existing defaults and removing overrides.

The first commit in this PR contains the config changes, the second is just the result of running yarn prettier-all.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 8:59pm

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I get the desire to have consistent configs, but I'm wondering if this warrants a discussion? We've used the existing settings for a while now so there's some familiarity with how it was formatted before. Makes sense to be consistent, but styling is subjective so I think it'd be worth getting everyone's thoughts before landing this one.

Sending back to your queue though to run yarn snap:build && yarn snap --update to update the snapshots

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like our old config better but accepting to unblock, could you also add the commit hash to the skiplist in https://github.com/facebook/react/blob/main/.git-blame-ignore-revs in once it lands?

@kassens
Copy link
Member Author

kassens commented Jul 18, 2024

I like our old config better but accepting to unblock, could you also add the commit hash to the skiplist in https://github.com/facebook/react/blob/main/.git-blame-ignore-revs in once it lands?

I think you can argue to make a change to the full react repo style if there's a change you'd like to introduce. Otherwise, I think default should be what React was using for most of the code?

@kassens kassens merged commit fd2b3e1 into facebook:main Jul 18, 2024
197 checks passed
@kassens kassens deleted the prettier branch July 18, 2024 21:00
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
Updates the prettier config to format all `.ts` and `.tsx` files in the
repo using the existing defaults and removing overrides.

The first commit in this PR contains the config changes, the second is
just the result of running `yarn prettier-all`.
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
Updates the prettier config to format all `.ts` and `.tsx` files in the
repo using the existing defaults and removing overrides.

The first commit in this PR contains the config changes, the second is
just the result of running `yarn prettier-all`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants