[compiler][be] Promote destructured params to temporaries #30332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 15, 2024
josephsavona
added a commit
that referenced
this pull request
Jul 15, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: 2e0aeb32c09d160a57b22093c51184a29fc08286 Pull Request resolved: #30332
facebook-github-bot
added
the
React Core Team
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jul 15, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: 2fbc1e51280adfcbc11b050bda3272f098608519 Pull Request resolved: #30332
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jul 15, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: 0e8cbc3a6ccdd331930cab46c77db6ae88d1e4f7 Pull Request resolved: #30332
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jul 15, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: 07d4ec0d7db3875833abd94d5a18df4b69969f05 Pull Request resolved: #30332
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jul 15, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: ec0c6bec7349c207770fb93dabb9253650f6f0fc Pull Request resolved: #30332
mvitousek
approved these changes
Jul 16, 2024
there was an existing fixture that failed without the fix, but i also added a new one specifically for this case. |
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jul 16, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: a6f665762ebcb7b06b118fcaf7515b8021645eae Pull Request resolved: #30332
poteto
approved these changes
Jul 16, 2024
josephsavona
added a commit
that referenced
this pull request
Jul 17, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: a6f665762ebcb7b06b118fcaf7515b8021645eae Pull Request resolved: #30332
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: a6f665762ebcb7b06b118fcaf7515b8021645eae Pull Request resolved: facebook#30332
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR. ghstack-source-id: a6f665762ebcb7b06b118fcaf7515b8021645eae Pull Request resolved: facebook#30332
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params always have to be named, so we can promote when constructing HIR.