Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Try sharding test_build #30349

Merged
merged 7 commits into from
Jul 16, 2024
Merged

[ci] Try sharding test_build #30349

merged 7 commits into from
Jul 16, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 16, 2024

Stack from ghstack (oldest at bottom):

The tests for the build currently take about 3.5 minutes and is at the
moment the long pole for the whole workflow. By sharding we can make
this workflow faster and save about a minute or so in overall wall time.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 4:13pm

poteto added a commit that referenced this pull request Jul 16, 2024
ghstack-source-id: 95dddc54b50745250431f35786144424ecba4f5f
Pull Request resolved: #30349
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 16, 2024
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 16, 2024
ghstack-source-id: 9932c84a040fd7b0a4a508ba651409d0153b0018
Pull Request resolved: #30349
@react-sizebot
Copy link

react-sizebot commented Jul 16, 2024

Comparing: 0117239...935e889

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.80 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 935e889

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@poteto poteto merged commit 935e889 into gh/poteto/34/base Jul 16, 2024
200 checks passed
poteto added a commit that referenced this pull request Jul 16, 2024
The tests for the build currently take about 3.5 minutes and is at the
moment the long pole for the whole workflow. By sharding we can make
this workflow faster and save about a minute or so in overall wall time.

ghstack-source-id: c23df7b6d7fd2df857abb976546456ca874d9151
Pull Request resolved: #30349
@poteto poteto deleted the gh/poteto/34/head branch July 16, 2024 16:32
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
The tests for the build currently take about 3.5 minutes and is at the
moment the long pole for the whole workflow. By sharding we can make
this workflow faster and save about a minute or so in overall wall time.

ghstack-source-id: c23df7b6d7fd2df857abb976546456ca874d9151
Pull Request resolved: facebook#30349
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
The tests for the build currently take about 3.5 minutes and is at the
moment the long pole for the whole workflow. By sharding we can make
this workflow faster and save about a minute or so in overall wall time.

ghstack-source-id: c23df7b6d7fd2df857abb976546456ca874d9151
Pull Request resolved: facebook#30349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants