[compiler] Always emit FuncDecl for outlined functions #30464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
Addresses follow up feedback from #30446. Since the outlined function is guaranteed to have a module-scoped unique identifier name, we can simplify the insertion logic for the outlined function to always emit a function declaration rather than switch based on the original function type. This is fine because the outlined function is synthetic anyway. ghstack-source-id: 0a4d1f7b0a5a34f8ed68c463b1a153c51c3ea75e Pull Request resolved: #30464
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Jul 25, 2024
mofeiZ
reviewed
Jul 25, 2024
| }, | ||
| ); | ||
| return insertedFuncExpr; | ||
| const insertedFuncDecl = varDecl.insertAfter(fn)[0]!; |
There was a problem hiding this comment.
Since we're not using the createNewFunctionNode helper here, let's manually exclude from re-compilation (ALREADY_COMPILED.add(transformedFn);)
ohh nvm, I see we're already doing this after calling insertNewOutlinedFunctionNode. please disregard!
poteto
commented
Jul 25, 2024
| @@ -482,7 +468,7 @@ export function compileProgram( | |||
| reason: 'Unexpected nested outlined functions', | |||
| loc: outlined.fn.loc, | |||
| }); | |||
| const fn = insertNewFunctionNode(current.fn, outlined.fn); | |||
| const fn = insertNewOutlinedFunctionNode(current.fn, outlined.fn); | |||
| fn.skip(); | |||
| ALREADY_COMPILED.add(fn.node); | |||
There was a problem hiding this comment.
@mofeiZ looks this is already skipped here
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
Addresses follow up feedback from #30446. Since the outlined function is guaranteed to have a module-scoped unique identifier name, we can simplify the insertion logic for the outlined function to always emit a function declaration rather than switch based on the original function type. This is fine because the outlined function is synthetic anyway. ghstack-source-id: 0a4d1f7b0a5a34f8ed68c463b1a153c51c3ea75e Pull Request resolved: #30464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Addresses follow up feedback from #30446. Since the outlined function is
guaranteed to have a module-scoped unique identifier name, we can
simplify the insertion logic for the outlined function to always emit a
function declaration rather than switch based on the original function
type. This is fine because the outlined function is synthetic anyway.