Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable_useContextWithBailout incorrect dispatcher assignment #30673

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix unstable_useContextWithBailout incorrect dispatcher assignment #30673

merged 1 commit into from
Aug 13, 2024

Conversation

jackpope
Copy link
Contributor

Fixing a mistaken copy from another dispatcher property assignment

@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 3:25pm

@jackpope jackpope requested review from gnoff and gsathya August 13, 2024 15:21
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Aug 13, 2024
@react-sizebot
Copy link

Comparing: 23830ea...0c032f3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9dade38

@jackpope jackpope merged commit d48603a into facebook:main Aug 13, 2024
185 checks passed
@jackpope jackpope deleted the fix-unstable_useContextWithBailout-dispatcher branch August 13, 2024 15:31
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
@jackpope
Fix unstable_useContextWithBailout incorrect dispatcher assignment (#…
b903fc0 
…30673)

Fixing a mistaken copy from another dispatcher property assignment

DiffTrain build for [d48603a](d48603a)
@eps1lon eps1lon mentioned this pull request Aug 14, 2024
Merged
jackpope added a commit to jackpope/react that referenced this pull request Dec 16, 2024
@jackpope
Revert "Fix unstable_useContextWithBailout incorrect dispatcher assig…
693d471 
…nment (facebook#30673)"

This reverts commit d48603a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsathya gsathya gsathya approved these changes

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @gsathya @facebook-github-bot