Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz][Static] when aborting a prerender halt unfinished boundaries instead of erroring #30732

Merged
merged 1 commit into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. [Fizz][Static] when aborting a prerender halt unfinished boundaries i…

    …nstead of erroring
    
    When we introduces prerendering for flight we modeled an abort of a flight prerender as having unfinished rows. This is similar to how postpone was already implemented when you postponed from "within" a prerender using React.unstable_postpone. However when aborting with a postponed instance every boundary would be eagerly marked for client rendering which is more akin to prerendering and then resuming with an aborted signal.
    
    The insight with the flight work was that it's not so much the postpone that describes the intended semantics but the abort combined with a prerender. So like in flight when you abort a prerender and enableHalt is enabled boundaries and the shell won't error for any reason. Fizz will still call onPostpone and onError according to the abort reason but the consuemr of the prerender should expect to resume it before trying to use it.
    gnoff committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    bf19314 View commit details
    Browse the repository at this point in the history