Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Rename Chunk constructor to ReactPromise #30747

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[Flight] Rename Chunk constructor to ReactPromise #30747

merged 1 commit into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. Rename Chunk constructor to ReactPromise 

    When printing these in DevTools they show up as the name of the constructor
so then you pass a Promise to the client it logs as "Chunk" which is confusing.

Ideally we'd probably just name this Promise but 1) there's a slight difference
in the .then method atm 2) it's a bit tricky to name a variable.
    @sebmarkbage
    sebmarkbage committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9067f28 View commit details
    Browse the repository at this point in the history