Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Source Map Actions in Reference Node Loader Transforms #30755

Merged
merged 4 commits into from
Aug 21, 2024
Merged

[Flight] Source Map Actions in Reference Node Loader Transforms #30755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4294898
Load source map when transforming modules
sebmarkbage Aug 20, 2024
74fb9c9
Update dependencies to include webpack-sources
sebmarkbage Aug 20, 2024
111c4ea
Generate appended source mappings pointing to the exports
sebmarkbage Aug 20, 2024
b3da2c2
Generate a simple source map if an existing one didn't exist
sebmarkbage Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fixtures/flight/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"react-dev-utils": "^12.0.1",
"react-dom": "experimental",
"react-refresh": "^0.11.0",
"react-server-dom-webpack": "experimental",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we need to update the build-for-flight-dev command but that already builds react-server-dom-webpack

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously just copied into the folder but that didn't make yarn consider its dependencies when resolving dependencies.

"resolve": "^1.20.0",
"resolve-url-loader": "^4.0.0",
"sass-loader": "^12.3.0",
Expand Down
2,166 changes: 1,411 additions & 755 deletions fixtures/flight/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion packages/react-server-dom-webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
},
"dependencies": {
"acorn-loose": "^8.3.0",
"neo-async": "^2.6.1"
"neo-async": "^2.6.1",
"webpack-sources": "^3.2.0"
}
}
Loading
Loading