Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Refactor Error / Warning Count Tracking #30899

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[DevTools] Refactor Error / Warning Count Tracking #30899

merged 2 commits into from
Sep 9, 2024

Commits on Sep 7, 2024

  1. Track logs per Fiber permanently in the global map 

    This is easier to track than moving back and forth between the pending set
and a set stashed on the instance.

Only send updates to the front end if counts changes. Only send updates
when the commit phase visits the instance. That way we don't need to look
it up globally.
    @sebmarkbage
    sebmarkbage committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    5509fd5 View commit details
    Browse the repository at this point in the history

  2. Brute force error/warning count to update if it happens in passive ef… 

    …fects

If a log is added in a passive effect it is too late for us to have picked
it up in the tree traversal so it won't show up until that component is
rerendered again.

To avoid needing a map to look up the instance id, we do a brute force
search over the whole tree to find any changes if this happens.
    @sebmarkbage
    sebmarkbage committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    ba63ff4 View commit details
    Browse the repository at this point in the history